LocalShop | Veterancraft Dedicated Server

Topic RSS

LocalShop

Topic Rating: +1 (1 votes)

May 16, 2015
10:47 am

AdmlAdama

Member

Members

Forum Posts: 111

Member Since:
April 21, 2015

Offline

Is this the plugin your using for bukkit 1.8?

https://github.com/MilkBowl/LocalShops

I was thinking about trying to contribute a fix for the inability to sell named/enchanted items by reviewing how they handle NBT tags.

However I wanted to be sure to work with the right one.

May 16, 2015
2:43 pm

Frenchy

Member

Viceroy

Members

Forum Posts: 185

Member Since:
June 23, 2013

Offline

We use JCShops, a custom mod made by frelling. It's unique to our server.

May 17, 2015
4:02 pm

AdmlAdama

Member

Members

Forum Posts: 111

Member Since:
April 21, 2015

Offline

Frenchy said

We use JCShops, a custom mod made by frelling. It's unique to our server.

Wonder if the source is published anywhere?

May 27, 2015
1:31 pm

frelling

Senior Tech

Forum Posts: 3264

Member Since:
August 18, 2011

Offline

JCShops originally was a continuation of LocalShops several years ago. Since then, it has become a mish-mash of patches, fixes, and improvements (when possible) of original features. JCShop is scheduled for a complete re-write, so if you have any suggestions, I'd be more than willing to talk more.

Human beings, who are almost unique in having the ability to learn from the experiences of others, are also remarkable for their disinclination to do so. - D. Adams

May 27, 2015
2:28 pm

Frenchy

Member

Viceroy

Members

Forum Posts: 185

Member Since:
June 23, 2013

Offline

If you are taking in suggestion, I do have one.

For any blocks of material (Gold, redstone, iron, etc) it's block, gold

However, for ingots it's gold ingot

Could you please make it so it's ingot, gold instead? I feel like it would streamline the system a bit.

May 31, 2015
12:22 pm

AdmlAdama

Member

Members

Forum Posts: 111

Member Since:
April 21, 2015

Offline

frelling said

JCShops originally was a continuation of LocalShops several years ago. Since then, it has become a mish-mash of patches, fixes, and improvements (when possible) of original features. JCShop is scheduled for a complete re-write, so if you have any suggestions, I'd be more than willing to talk more.

Sounds great. We can further discuss when things settle but off the top of my head
* wildcard search - such as /shop find like iron would return names matching like this
The following items match
Iron ingot 2 shops
Block, iron 0 shops
Iron gates 1 shop

* shop info including location details
/shop find cocoa beans
Returns the normal shop name and inventory including a shops name

So let's say I want to find it
/shop describe wwcf
Returns this
name: WWCF
About: Willie Wonkas chocolate factory. Come to us for all your baking needs
Location: 1111,22,3333
Distance: 100m

* custom enchanted and named items with NBT tags
I realize that the hardest part of this is the name/describe info of items. As such I'd suggest having moon items already there such as sword diamond unb3 loot3
But for some odd arrangement of books be able to ad a custom description such as super rangasp special bow (NBT summary here such as enchant, etc)
To keep things simple I'd recommend full durability only.

As far as describing items I can look at making an item name parser that takes an NBT tag and returns a short and long descriptive name. Something that can be plugged into your code base as a separate included class to make it easier to work with

June 2, 2015
4:13 pm

tedisvet

The Netherlands

Member

Members

Forum Posts: 135

Member Since:
February 19, 2015

Offline

AdmlAdama said

frelling said

JCShops originally was a continuation of LocalShops several years ago. Since then, it has become a mish-mash of patches, fixes, and improvements (when possible) of original features. JCShop is scheduled for a complete re-write, so if you have any suggestions, I'd be more than willing to talk more.

Sounds great. We can further discuss when things settle but off the top of my head
* wildcard search - such as /shop find like iron would return names matching like this
The following items match
Iron ingot 2 shops
Block, iron 0 shops
Iron gates 1 shop

* shop info including location details
/shop find cocoa beans
Returns the normal shop name and inventory including a shops name

So let's say I want to find it
/shop describe wwcf
Returns this
name: WWCF
About: Willie Wonkas chocolate factory. Come to us for all your baking needs
Location: 1111,22,3333
Distance: 100m

* custom enchanted and named items with NBT tags
I realize that the hardest part of this is the name/describe info of items. As such I'd suggest having moon items already there such as sword diamond unb3 loot3
But for some odd arrangement of books be able to ad a custom description such as super rangasp special bow (NBT summary here such as enchant, etc)
To keep things simple I'd recommend full durability only.

As far as describing items I can look at making an item name parser that takes an NBT tag and returns a short and long descriptive name. Something that can be plugged into your code base as a separate included class to make it easier to work with

I am not that good (yet) with programming, and I can only help with ideas, I am not sure if this is possible. But something to make it better visible where the shops are when you use /shop find <item>. When I was fairly new I spent 15-20 minutes on finding a shop in NG.

It isnt a really big problem if you create the big signs greens made in NM, but it could be a nice addition if it isnt too much work!

Goodluck!