Log In
Register
Home
Topic RSS
Related Topics
10:11 am
April 5, 2013
Offline
Here are the commands I have tried, and the results I got.
On first add with nearly a full inventory of oak leaves, by using /shop add lea oak all:
Results: Successfully added Leaves, Oak to the shop. Stock is now 0. Leaves, Oak is almost ready to be purchased or sold!" (and then the /shop command prompts.)
Holding a stack in my hand:
/shop add all
Results: "Could not find an item."
With it just in my inventory:
/shop add lea oak all
/shop add Leaves, Oak all
Results: "Greens, Eggs, and Ham already carries Leaves, Oak!"
Trying with the item code rather than name, in various configurations:
/shop add #0018/0 all
/shop add 0018/0 all
/shop add #0018 all
/shop add 0018 all
Results on all: "Could not find an item."
Additional info:
I am definitely standing inside my shop while doing this.
I'm not having this issue with non-leaf blocks that have more than one word in the name (lily pads work fine, for example.)
This may be an issue with all leaves, since I get the same thing with birch and spruce. Haven't tried jungle yet.
It may be just a word length thing, but signs reflect the names of the leaves differently. Screenshot attached.
Thanks for your time.
12:35 pm
January 21, 2013
Offline
this may, or may not, be related to a bug that i noticed lately - if you hover with your mouse over any leaves block, it always says "leaves, oak" (regardless if it's really spruce, birch or jungle)
3:15 pm
August 18, 2011
Offline
I will have to look into it. Mojang did change several item ids during the last release. What is the name of the shop and where is it located (coordinate are sufficient)?
3:19 pm
Staff Alumni
February 1, 2012
Offline
-150 65 765 (Green, Eggs, and Ham)
2:43 am
January 21, 2013
Offline
hmm i just did some testing, and i was able to successfully add oak, jungle and spruce (didn't try birch) leaves to my shop, set a price for them, and buy them. I just held the item in hand and did "/shop add all" to add it.
Oh btw. item codes (visible with F3+H) for me were
#0018/4 (oak) #0018/5 (spruce) and #0018/7 (jungle)
maybe there are different leaves blocks? i was having those that jcshops liked (4-7?) while you might have been trying to add those jcshops doesn't know? (0-3?) just a shot in the dark here
EDIT: further testing (getting fresh leaves from a spruce tree) shows item code #0018/1 (while the old spruce leave blocks i had in some chest had the code #0018/5) i was unable to add the new leaves to the shop. it only works with the old leaves code - it should be easy to change the item codes for these 4 items, the only problem will be that "old" leaves blocks won't be able to be added to shops anymore then.
6:39 am
June 20, 2011
Offline
Sounds like the item IDs changed with the 1.5 update.
7:43 am
April 5, 2013
Offline
If the item codes changed, that would explain why I have some leaf blocks harvested prior to the upgrade which won't stack with ones harvested after.
Thanks for your work confirming the problem, Adituno. Helps to know it's not just me doing something wrong.
9:13 am
August 18, 2011
Offline
Ah, I think you may have have solved your own problem. mcMMO used to create some funky variations of items with special data values. I thought they stopped doing that, maybe not. This is particularly true for leaves, sandstone, redstone blocks (using Silk Touch) that "double drop" whenever an ability fires.
9:56 am
April 5, 2013
Offline
frelling said
Ah, I think you may have have solved your own problem. mcMMO used to create some funky variations of items with special data values. I thought they stopped doing that, maybe not. This is particularly true for leaves, sandstone, redstone blocks (using Silk Touch) that "double drop" whenever an ability fires.
I don't think this is the answer, because the non-oak ones I'm trying to stock are new, harvested yesterday. After I couldn't add the oak leaves, I went and grew some birch and spruce so I'd have fresh leaves to try with.
I placed the saplings, grew them with dust, and harvested the leaves with shears. No enchantments to another tool, no tree feller used.
The ones that won't stack are just a couple I have stashed in a chest.
I also think that if it was just me trying to stock old ones, Adituno wouldn't have been able to duplicate the problem.
What do you think?
11:08 am
January 21, 2013
Offline
from http://www.minecraftwiki.net/w.....on_history :
1.4.6: (dec. 20, 2012) Fixed leaves obtained using Silk Touch having the wrong tooltip and data value
i think naturally grown leave blocks have different data (value 4-7) - to discern them from player placed leaves (value 0-3)
(naturally grown leaves decay when not supported properly)
before the 1.4.6 change you would get leaves with a data value of 4-7 (maybe only when using silk touch? or always when using shears) - since the change you can no longer get items with data value of 4-7 (even if you place a leaves block with that data value, when you pick it up again, it will be in the 0-3 range)
too bad that jcshops is using the obsolete data values. but i guess this can be fixed relatively easily (or just wait for the next patch)
9:31 pm
August 18, 2011
Offline
As Adituno stated, its an easy fix. Thanks for the quick history too, as it triggered a memory. I looked back into JCShops' revision history and found an old unresolved action item to revisit item/data values for Leaves. Current Leaves item/data values are still based on the original LocalShops plugin. Frankly, I'm surprised that it took this long for someone to uncover this issue. Guess selling leaves isn't a profit center 
In short it is an item id conflict as I suspected. Here is what is going to happen:
- JCShops will be updated to use correct Leaves item/data values.
- Shop inventories will also be updated ensuring that shops will buy and sell the correct type. No need to remove items from shops and re-add them.
- Any older Leave types contained in chests or player inventories can be converted into their correct type by placing them in a crafting window.
6:04 am
January 21, 2013
Offline
thanks for the quick resolve!
however, the converting recipes don't work for me (tried #0018/5 and #0018/7) i get a "You do not have permission to craft that item!" message
6:46 am
April 5, 2013
Offline
Thank you so much for fixing this!
I've added all three leaf types to my shop, though I did have to take the signs down and put them back again. Probably because they were reflecting the old IDs.
I didn't have any trouble converting old leaves to new ones, though.
7:00 pm
August 18, 2011
Offline
summertree said
Thank you so much for fixing this!I've added all three leaf types to my shop, though I did have to take the signs down and put them back again. Probably because they were reflecting the old IDs.
I didn't have any trouble converting old leaves to new ones, though.
Glad to hear of your success.
5:28 am
January 21, 2013
Offline
summertree said
I didn't have any trouble converting old leaves to new ones, though.
odd. i still get the same error message:
"You do not have permission to craft that item!"
It's the same message as the day before the rube goldberg competition with all redstone recipes.
If you could do it, then maybe only donors can? i'm not a donor 
7:41 pm
August 18, 2011
Offline
Adituno said
summertree said
I didn't have any trouble converting old leaves to new ones, though.odd. i still get the same error message:
"You do not have permission to craft that item!"
It's the same message as the day before the rube goldberg competition with all redstone recipes.
If you could do it, then maybe only donors can? i'm not a donor
It would help if I pulled the right configuration branch down onto the server. Should be working now as expected. - crossing fingers
Most Users Ever Online: 734
Currently Online:
1 Guest(s)
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Emulated: 3206
ryanpitts: 1300
Dalferes: 747
Pherian: 660
Okarim: 594
Member Stats:
Guest Posters: 10
Members: 27618
Moderators: 3
Admins: 2
Forum Stats:
Groups: 8
Forums: 45
Topics: 6229
Posts: 27413
Newest Members: Samanthaed, Natallyjerly, Wuhecoorn, JacobTak, Elizabethno, EcfDuede, lorenexi18, Christianzq, Jonathanin, Julioabelt, CarlosDonnA, elmeruh69, GarryGap, Laurenpu, kk4, ashleyqz16, Neessiz, jeanninehq1, shereeqc3, Matthewlw
Moderators: terrorisly: 424, mudwog: 127, LightWarriorK: 2154
Administrators: meatbawllz: 2475, frelling: 3264
